openerp-dev-web team mailing list archive

["Vo Minh Thu \(OpenERP\)" <vmt@xxxxxxxxxxx>]

Review: Needs Fixing
I still don't think it is a good idea to have such code lying aroung in our repo. A bit of documentation would be much better.

Anyway if you really want to have it, I would like you to:
- add comments as the code is for redhat only, and thus move it to a redhat only directory
- add comments saying where the code comes from (if applicable)
- provide a link to the documentation

Also, next time try to make clear your patch is for 6.0 because of packaging, otherwise it would be rejected and (possibly) accepted on the trunk only.

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/6.0-bug-757432-xrg/+merge/57301
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/6.0-bug-757432-xrg.