← Back to team overview

openerp-dev-web team mailing list archive

Re: [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara into lp:openobject-addons

 

Review: Needs Fixing
Hello,

Yes we are getting period_id in vals and we should use it.
so defining period_id at begining of the method seems ok but at the time of condition:

journal = journal_obj.browse(cr, uid, journal_id, context=context)
if journal.allow_date and period_id:

we should use period_id from vals.

thanks,
mra




-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-783994-ara/+merge/61545
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara.


References