openerp-dev-web team mailing list archive

Thread
Date

Re: [Merge] lp:~openerp-dev/openobject-server/trunk-bug-640677-nco into lp:openobject-server

To: mp+61564@xxxxxxxxxxxxxxxxxx
From: "Vo Minh Thu \(OpenERP\)" <vmt@xxxxxxxxxxx>
Date: Tue, 24 May 2011 15:27:35 -0000
In-reply-to: <20110519130729.23915.60381.launchpad@loganberry.canonical.com>
Reply-to: mp+61564@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Thanks for the merge proposal but I have a few questions.

What happens if self.localcontext is False? newtext won't be defined...

What's wrong with the line node.text = newtext? Is node.text reused later and we don't want to touch it?

Can you tell me how to reproduce the bug?
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-640677-nco/+merge/61564
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bug-640677-nco.

References

[Merge] lp:~openerp-dev/openobject-server/trunk-bug-640677-nco into lp:openobject-server
From: Nimesh Contractor(Open ERP), 2011-05-19