openerp-dev-web team mailing list archive

Thread
Date

Re: [Merge] lp:~openerp-dev/openobject-server/trunk-bug-781967-ysa into lp:openobject-server

To: "Yogesh\(Open ERP\)" <ysa@xxxxxxxxxxx>
From: "Vo Minh Thu \(OpenERP\)" <vmt@xxxxxxxxxxx>
Date: Wed, 25 May 2011 09:22:23 -0000
In-reply-to: <20110524064231.22412.10378.launchpad@loganberry.canonical.com>
Reply-to: mp+62079@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove
I could repeat my first comment almost as is...

Just below your modification, there is a call to file_open. That function has some logic to deal with the addons paths. There shouldn't be any reason to add more weird logic outside of it.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-781967-ysa/+merge/62079
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bug-781967-ysa.

References

[Merge] lp:~openerp-dev/openobject-server/trunk-bug-781967-ysa into lp:openobject-server
From: Yogesh(Open ERP), 2011-05-24