← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-client/trunk-usability-find_button-rmu into lp:~openerp-dev/openobject-client/trunk-usability

 

RavishchandraMurari(OpenERP) has proposed merging lp:~openerp-dev/openobject-client/trunk-usability-find_button-rmu into lp:~openerp-dev/openobject-client/trunk-usability.

Requested reviews:
  Amit (Open ERP) (apa-tiny)
  Naresh(OpenERP) (nch-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-client/trunk-usability-find_button-rmu/+merge/62267

Hello sir,

removed duplicate code.


Thanks,
Ravish
-- 
https://code.launchpad.net/~openerp-dev/openobject-client/trunk-usability-find_button-rmu/+merge/62267
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client/trunk-usability.
=== modified file 'bin/openerp.glade'
--- bin/openerp.glade	2011-02-09 05:53:41 +0000
+++ bin/openerp.glade	2011-05-25 10:09:33 +0000
@@ -3242,20 +3242,6 @@
               </widget>
             </child>
             <child>
-              <widget class="GtkButton" id="button81">
-                <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="can_default">True</property>
-                <property name="has_default">True</property>
-                <property name="label">gtk-find</property>
-                <property name="use_stock">True</property>
-                <property name="response_id">-10</property>
-              </widget>
-              <packing>
-                <property name="position">1</property>
-              </packing>
-            </child>
-            <child>
               <widget class="GtkButton" id="cancelbutton9">
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>

=== modified file 'bin/widget/view/screen_container.py'
--- bin/widget/view/screen_container.py	2011-04-13 08:42:29 +0000
+++ bin/widget/view/screen_container.py	2011-05-25 10:09:33 +0000
@@ -130,9 +130,14 @@
 
         button_clear = gtk.Button(stock=gtk.STOCK_CLEAR)
         button_clear.connect('clicked', screen.search_clear)
+
+        self.button = gtk.Button(stock=gtk.STOCK_FIND)
+        self.button.connect('clicked', screen.search_filter)
+
         if self.win_search:
             hb3 = hb1
             hs.pack_start(hb3, expand=False, fill=False)
+            hb3.pack_start(self.button, expand=False, fill=False)
             hb3.pack_start(button_clear, expand=False, fill=False)
         else:
             hb1.set_spacing(5)
@@ -143,8 +148,6 @@
             hs.pack_end(hb3, expand=False, fill=False)
 
     #Find Clear Buttons
-            self.button = gtk.Button(stock=gtk.STOCK_FIND)
-            self.button.connect('clicked', screen.search_filter)
             self.button.set_property('can_default', True)
             hb1.pack_start(self.button, expand=False, fill=False)
             hb1.pack_start(button_clear, expand=False, fill=False)


Follow ups