openerp-dev-web team mailing list archive

["qdp \(OpenERP\)" <qdp-launchpad@xxxxxxxxxxx>]

Review: Needs Fixing
I fixed that. Please have a look

1) did a case-insensitive str.replace

import re
pattern = re.compile("hello", re.IGNORECASE)
pattern.sub("bye", "hello HeLLo HELLO")

2) already_id in def execute was unused

3) if i understand correctly what you've done, already_id in translation_done method was used only for menus, because the name of menu are translate=True, then you need to write on the existing translation instead of creating a new one, right? well this was not good:
- it's not taking into account the normal fields with translate=True
- the code is really complex for nothing and unreadable

4) the name of variables and functions should be more appropriated. example: make_translations() instead of translations_done() 

5) ir.ui.menu and ir.model.fields are not enough... we need that also for ir.act.window + for menu tips and help tooltips of fields


and once i've done that, i merged that branch in trunk. Please be more accurate next time.

Thanks,
Quentin
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-product-terminlg-aag/+merge/61345
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework.