← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-addons/trunk-usability-product-search-view-pos-tta into lp:~openerp-dev/openobject-addons/trunk-usability

 

Review: Needs Fixing
There is a little issue: the menuitem 'product.menu_products' is defined in module product (product/product_view.xml).  We should make sure that both modules are consistent.  Notice that module sale imports stock, which imports product.

I propose the following:
 - move the action 'product_normal_action_sell' to product/product_view.xml
   (right below the action 'product_normal_action')
 - in product/product_view.xml, change menuitem 'menu_products' to use 'product_normal_action_sell'
 - in sale/sale_view.xml, delete the redefinition of menuitem 'product.menu_products', because it is identical

Does it seem fine to you?

Thanks,
Raphael

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-usability-product-search-view-pos-tta/+merge/62420
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-usability.


References