openerp-dev-web team mailing list archive

Thread
Date

Re: lp:~openerp-dev/openobject-server/trunk-factored-create-instance-vmt into lp:openobject-server

To: mp+62473@xxxxxxxxxxxxxxxxxx
From: "Christophe \(OpenERP\)" <christophe@xxxxxxxxxxx>
Date: Thu, 26 May 2011 12:39:30 -0000
In-reply-to: <20110526121428.19413.45163.launchpad@loganberry.canonical.com>
Reply-to: mp+62473@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Line 25 (of patch): no need to check the type of parent_names, it is already done at line 16
Line 27: assert must be used to check invariants (post conditions), not for checking validity of input. raise TypeError instead (like line 23)
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-factored-create-instance-vmt/+merge/62473
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-factored-create-instance-vmt.

References

lp:~openerp-dev/openobject-server/trunk-factored-create-instance-vmt into lp:openobject-server
From: Vo Minh Thu (OpenERP), 2011-05-26