← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi into lp:~openerp-dev/openobject-addons/trunk-payroll

 

Review: Needs Fixing
To be improve/fix:

1. required=False remove from register_id field
2. Total at last row should be shift down to amount column
3. for payslip lines ir.values => id="hr_holidays_summary_employee_value"? 
4. data on print_report method should be directly assign to form key
5. unused varible localdict in report py
6. from tools.safe_eval import safe_eval as eval unused? 
 
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi/+merge/61374
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll.


References