← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-server/trunk-bug-trml2pdf_improvement-nco into lp:openobject-server

 

Nimesh Contractor(Open ERP) has proposed merging lp:~openerp-dev/openobject-server/trunk-bug-trml2pdf_improvement-nco into lp:openobject-server.

Requested reviews:
  Naresh(OpenERP) (nch-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-trml2pdf_improvement-nco/+merge/62851

improvement in the code for the image in the trml2pdf.py 

thank you,
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-trml2pdf_improvement-nco/+merge/62851
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bug-trml2pdf_improvement-nco.
=== modified file 'openerp/report/render/rml2pdf/trml2pdf.py'
--- openerp/report/render/rml2pdf/trml2pdf.py	2011-05-25 08:09:21 +0000
+++ openerp/report/render/rml2pdf/trml2pdf.py	2011-05-30 09:14:24 +0000
@@ -447,14 +447,14 @@
                 self._logger.debug("Image %s used", node.get('name'))
                 s = StringIO(image_data)
             else:
+                newtext = node.text
                 if self.localcontext:
-                    res = utils._regex.findall(node.text)
+                    res = utils._regex.findall(newtext)
                     for key in res:
-                        newtext = eval(key, {}, self.localcontext)
-                        node.text = newtext or ''
+                        newtext = eval(key, {}, self.localcontext) or ''
                 image_data = None
-                if node.text:
-                    image_data = base64.decodestring(node.text)
+                if newtext:
+                    image_data = base64.decodestring(newtext)
                 if image_data:
                     s = StringIO(image_data)
                 else:


Follow ups