← Back to team overview

openerp-dutch team mailing list archive

[Bug 531507] Re: [PATCH] account module quite severe issues with closing fiscal years

 

It's been over two months by now, so my memory is a bit vague, but IIRC,
the two scenario's we encountered were:

* invoices are all paid & reconciled, all fiscal years are open.

* invoice in 2002, with several payments in 2003. Close 2002 and each invoice account_move_line in 2002 will appear N payments in the closing account_move. This is simply, though not very elegantly, fixed by adding the DISTINCT-clause, as seen in the patch.
Try the SQL against a db in these conditions and you will see this happening for yourself without actually closing anything.

* invoice in 2002, payment in 2004. When closing 2002 this won't work because payment won't be picked up, when subsequently closing 2003, it still won't work because the invoice won't be picked up.
This is fixed by including /all/ next, previous periods respectively in the associated period sets, as seen in the patch.

-- 
[PATCH] account module quite severe issues with closing fiscal years
https://bugs.launchpad.net/bugs/531507
You received this bug notification because you are a member of OpenERP
Dutch Team - Nederland, which is the registrant for OpenERP Dutch
Lokalisatie Project - Nederland.

Status in OpenERP-Dutch-localisation: Fix Committed
Status in OpenObject Addons Modules: Incomplete

Bug description:
We have identified two major issues with the wizard_fiscalyear_close in the account module in any 5+ version of OpenERP:

1) As noted in the wizard_fiscalyear_close.py (~line 145):
                #TODO: this query could be improved in order to work if there is more than 2 open FY
                # a.period_id IN ('+fy2_period_set+') is the problematic clause
2) When a reconcile crosses years AND the reconciliation in the new years contains N entries, each reconciled entry in the old year will get reported N times instead of once.

These bugs will quite possibly crap up closing a year, and we consider them therefore to be quite important.