openerp-dutch team mailing list archive

["Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>]

Jay, Quentin,

We have checked this issue and patch provided by 'The Loeki', and they seem valid (according to our quick review with fp). The SELECT DISTINCT one seems obvious if you look carefully at the query.
Could you check this patch and the described testcase  thoroughly and implement the appropriate fix in both 5.0 and trunk?

Thanks!

-- 
[PATCH] account module quite severe issues with closing fiscal years
https://bugs.launchpad.net/bugs/531507
You received this bug notification because you are a member of OpenERP
Dutch Team - Nederland, which is the registrant for OpenERP Dutch
Lokalisatie Project - Nederland.

Status in OpenERP-Dutch-localisation: Fix Committed
Status in OpenObject Addons Modules: Confirmed

Bug description:
We have identified two major issues with the wizard_fiscalyear_close in the account module in any 5+ version of OpenERP:

1) As noted in the wizard_fiscalyear_close.py (~line 145):
                #TODO: this query could be improved in order to work if there is more than 2 open FY
                # a.period_id IN ('+fy2_period_set+') is the problematic clause
2) When a reconcile crosses years AND the reconciliation in the new years contains N entries, each reconciled entry in the old year will get reported N times instead of once.

These bugs will quite possibly crap up closing a year, and we consider them therefore to be quite important.