openerp-expert-accounting team mailing list archive

["Olivier Dony \(OpenERP\)" <603095@xxxxxxxxxxxxxxxxxx>]

@vra: as Jay says, your patch is incomplete because you are bypassing the second 'open' (act_open_test) activity of the workflow, so you need to choose: if you bypass it you should remove it and check the whole logic, or don't bypass it and do it like Jay suggests, with a transition back from act_open_test. 
I agree that the act_open_test activity is not well named (should be 'act_re_open' or something) so it is confusing, but it seems its goal is to avoid calling again the other methods called by the original 'open' activity. For example if the invoice has a payment term your patch will recompute it, which is not correct.

@Jay: Your patch looks correct to me for 5.0. Now for trunk, I think we need to improve this even further. My suggestions: 
 - either we remove the 'act_open_test' activity + guard better all the methods called by 'open' activity so they don't do their job twice (mainly action_date_assign()), then connect 'paid' back to 'open' directly, which looks much more intuitive to me ;
 - or at least rename 'act_open_test' to 're_open', and all related names ;
And while we're improving trunk: do we need an actual wizard for the confirmation of the 're-open' button when it seems a simple 'confirm' attribute would be sufficient?

-- 
When an invoice is reopened, it cannot be changed to Done state anymore.
https://bugs.launchpad.net/bugs/603095
You received this bug notification because you are a member of OpenERP
Accounting Experts, which is a direct subscriber.

Status in OpenObject Addons Modules: In Progress

Bug description:
When an invoice is reopened, it cannot be changed to Done state anymore. The boolean "Paid/Reconciled" is checked but it remains in Open state.

Follow these steps:

1) Create an invoice and validate (State: Open)
2) Pay the invoice (with Pay Invoice wizard or reconciling the partner account move line) (State: Done)
3) Break the reconciliation of this invoice, and Reopen it (State: Open)
4) If you pay the invoice another time (with Pay Invoice wizard or reconciling the partner account move line), the "Paid/Reconciled" boolean is checked but the Open state does not change to Done state.

Tested in last version of 5.0 (not in trunk, but maybe trunk has a similar behaviour).