← Back to team overview

openerp-expert-accounting team mailing list archive

Re: [Bug 912631] Re: [stock] product.product method get_product_accounts just check the first level category_id in stock_valuation

 

I don't know.  It sounds great in theory, and for a long time I wanted that
as the default behaviour.  But I kind of like it now in that it is explicit
that the values in the product category are the values.  Because they are
all property fields I can just see it being a mess from a user perspective.
 Is the field blank because a different company created the category,
moreoever - now that it is blank it will still pull an account from
somewhere is it even taking the right accounts?  What if I change its
parent, etc etc (of course the reverse is true, if I change its parent I
might be doing so to change the accounts)

Scenario - new category by Company A for some new products (by default
shared company wide).  To be measured in separate account say Product A
Revenue instead of General Sales.  All works well for Company A as they set
up the category.  Now smart salesperson from Company B sells it and instead
of throwing an error and alerting accounts it just flows through.

In the current scenario, one sale, error thrown, problem corrected by
accounts.
In the proposed scenario, many sales, maybe even to end of a fiscal or
longer.

I know its a pain to setup product categories properties when you have a
lot of them (we use 78 shared over 6 companies) and you can't just SQL
them, but csv import works, and KOO supports updating multiple objects so
I'd rather see this as a seperate module.

Also get_product_accounts is from memory only used by 1 other function as a
helper function.  There are many many other modules that access product
accounts information.  I'm not saying thats right, but just reality.
 Anglosaxon is just one that will break.

On Sat, Feb 18, 2012 at 1:39 PM, hbto [Vauxoo] http://www.vauxoo.com <
humbertoarocha@xxxxxxxxx> wrote:

> Hello, Kevin,
>
> this module is addressing this problem right now,
> will a solution is reached
>
>
> http://bazaar.launchpad.net/~inddiana/sisb/sisb/files/head:/product_category_account
>
> Regards,
>
> Hbto [VAUXOO]
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/912631
>
> Title:
>  [stock] product.product method get_product_accounts just check the
>  first level category_id in stock_valuation
>
> Status in OpenERP Addons (modules):
>   Confirmed
>
> Bug description:
>  [stock] product.product method get_product_accounts just check the
>  first level category_id
>
>  When trying to get the accounting account for stock_[in/out]
> variation_account and journal_id
>  from a category_id this method just go up to the first level and does not
> check upper levels
>  which would avoid a lot of problems because those upper level could
> provide the missing parameters
>  lacking to accomplish stock valuation
>
>  the patch provide could avoid that, is simple is easy to use and quite
> possible would not break any
>  backward compatibility.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/912631/+subscriptions
>

-- 
You received this bug notification because you are a member of OpenERP
Accounting Experts, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/912631

Title:
  [stock] product.product method get_product_accounts just check the
  first level category_id in stock_valuation

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  [stock] product.product method get_product_accounts just check the
  first level category_id

  When trying to get the accounting account for stock_[in/out] variation_account and journal_id 
  from a category_id this method just go up to the first level and does not check upper levels
  which would avoid a lot of problems because those upper level could provide the missing parameters
  lacking to accomplish stock valuation

  the patch provide could avoid that, is simple is easy to use and quite possible would not break any
  backward compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/912631/+subscriptions


Follow ups

References