← Back to team overview

openerp-expert-framework team mailing list archive

Re: [Bug 634634] Re: Searching on float fields does not work properly

 

On Friday 10 September 2010, you wrote:
> On Friday 10 September 2010, you wrote:
> > ** Patch added: "expression.py.diff"
> > 
> > https://bugs.launchpad.net/bugs/634634/+attachment/1563966/+files/express
> > i on.py.diff
> 
> Your patch is not wrong, but it makes me wonder:
> 
> why do we have the _symbol_c and _symbol_f like that now?
> Why do we default to a 0.0 float, when we could even have NULL values?
> 
> I guess, blindly changing them might break *a lot* of assumptions in
> modules, but shouldn't we think of null values and also perform less
> conversions?

I have "blindly" changed the symbol_set for integer, bigint, floats and am 
running my server like that since 1-2 days. (commits, of course, are public in 
my pg84 branch).

It surely breaks quite some code. (although I put a "compatibility" snippet 
there). 

I know this feature (allowing Null/None at numeric fields) has been desirable. 
But it will need porting for many modules, it will have side-effects.




References