openerp-expert-framework team mailing list archive
-
openerp-expert-framework team
-
Mailing list archive
-
Message #00605
Re: New cache system broke translation ?
-
To:
Openerp Expert Framework <openerp-expert-framework@xxxxxxxxxxxxxxxxxxx>
-
From:
Olivier Dony <odo@xxxxxxxxxxx>
-
Date:
Tue, 13 Sep 2011 20:01:41 +0200
-
In-reply-to:
<CAJ=p=OidbTDHL7t2dPDueqYRkrNfo5qyYkOqHrMMOWw48MDXzQ@mail.gmail.com>
-
Organization:
OpenERP s.a.
-
User-agent:
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Thunderbird/3.1.13
On 09/13/2011 04:42 PM, Thibaut DIRLIK wrote:
> I'm using the latest rev, just updated, same problem. I saw the commit
> of Antonny Lesuisse about the fix, but it doesn't fix the part of the
> code I talked about
Indeed, that's the last place where _get_ids.clear_cache() was being
called - Antony must have missed it too during the merge of the new cache.
Bit of context: the new cache implementation is faster and simpler, and
it supports the "multi" use case (@tools.ormcache_multi).
With the multi-valued version, the cache knows that one of the method
parameters is a list of keys, in which case the result is cached for
each key individually, allowing a cache hit next time any one of these
keys is requested.
However, contrary to the old cache implementation, this implementation
does not (yet) support the same multi-value behavior for the clearing of
the cache with cache_clear(), so the multiple keys need to be cleared
separately.
It should be fixed after revision 3588. Checked the rest of the code,
this was the last call to ormcache_multi.cache_clear() with a list of keys.
Thanks for spotting it! And since you asked: yes, this would of course
have been appreciated as a LP bug report, or a comment/reopen on bug
838864 :-)
Follow ups
References