← Back to team overview

openerp-expert-framework team mailing list archive

Re: Mass_editing module

 

Stefan,

Reverted the code and proposed a branch.

https://code.launchpad.net/~serpent-consulting-services/server-env-tools/mass_editing_7.0/+merge/148245

Feel free to say what needs fixing!

Thanks.

On Wed, Feb 13, 2013 at 10:10 PM, Stefan Rijnhart <stefan@xxxxxxxx> wrote:

>  Hi,
>
> Can I push this a bit further and ask you to revert by committing a
> reverse merge, then propose a merge request? I see an issue that I think
> needs fixing. Or is there a better procedure for post hoc review?
>
> Cheers,
> Stefan.
>
>
>
>
>
> On 13-02-13 16:06, Er. Jay Vora wrote:
>
> Completely understood!
>
> On Wed, Feb 13, 2013 at 8:24 PM, Joël Grand-Guillaume <
> joel.grandguillaume@xxxxxxxxxxxxxx> wrote:
>
>> Yes Jay, please do not break the rule we're trying to make there. Thanks
>> to make a MP next time. It's important that reviewers show example. It's
>> already not easy to convince some others...
>>
>>  Thanks for your understanding !
>>
>>  Regards,
>>
>>  Joël
>>
>>
>>
>>  Le 13 févr. 2013 à 14:59, Serpent Consulting Services <
>> serpentcs.lp@xxxxxxxxx> a écrit :
>>
>>  Alexandre,
>>
>> Noted with Thanks!
>>
>> On Wednesday 13 February 2013 07:22 PM, Alexandre Fayolle wrote:
>>
>> Hello,
>>
>> Using an MP to follow the community review process would have been so
>> much better. Being a reviewer yourself means you were able to push on the
>> branch, but it's not a reason to do so bluntly.
>>
>> A review would have given us the opportunity to point out that you have
>> not used the bzr history preserving extraction tool, for instance...
>>
>> Alexandre
>>
>> On 13/02/2013 14:40, Er. Jay Vora wrote:
>>
>> Hello Community,
>>
>> Here goes the mass_editing module for OpenERP Version 7.0.
>>
>> It has been committed to
>> https://code.launchpad.net/~server-env-tools-core-editors/server-env-tools/7.0,
>> the initiative of CamptoCamp.
>>
>> As asked by few members by email, we have added a little video as well :
>> http://youtu.be/9BH0o74A748
>>
>> Thank you and have a happy day ahead!
>>
>> On Wed, Feb 13, 2013 at 2:58 PM, Serpent Consulting Services <
>> serpentcs.lp@xxxxxxxxx> wrote:
>>
>>>  Joël,
>>>
>>> Sure, this makes more sense!
>>>
>>> Better to have a common branch!
>>>
>>> We will do it today and notify the community!
>>>
>>> Thanks.
>>>
>>>  Wednesday 13 February 2013 01:59 PM, Joël Grand-Guillaume wrote:
>>>
>>> Hi,
>>>
>>>
>>>  That's very goods news ! May I suggest this community branch :
>>> https://launchpad.net/server-env-tools ?
>>>
>>>  Or do you think of another more appropriate ?
>>>
>>>  Regards,
>>>
>>>
>>>  Joël
>>>
>>>
>>>
>>>
> --
> Therp - Maatwerk in open ontwikkeling
>
> Stefan Rijnhart - Ontwerp en implementatie
>
> mail: stefan@xxxxxxxx
> tel: +31 (0) 614478606http://therp.nlhttps://twitter.com/therp_stefan
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-expert-framework
> Post to     : openerp-expert-framework@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-expert-framework
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 

Thanks,
Regards,

*Er. Jay Vora*
M : 91 - 9879354457.
(Not miles, just an email away...)
Twitter <http://twitter.com/#%21/jaynvora>
Facebook<http://www.facebook.com/jaynvora>
LinkedIn <http://www.linkedin.com/in/jaynvora>
Blogger<http://jayvora.blogspot.com>
"No Seconds to be Wasted for Formalities, I have a lot to Execute !" - Jay
Vora

Follow ups

References