← Back to team overview

openerp-expert-framework team mailing list archive

Re: Dependency of current trunk on requests

 

On 08/01/2013 11:35 AM, Georges Racinet wrote:
Hi all,

Hi Georges,

as one of our users noticed, a dependency to 'requests' has been
recently added to the current trunk of OpenERP
Without it, the web module does not load.

(for ref: https://bugs.launchpad.net/anybox.recipe.openerp/+bug/1205920)

Is there a reason not to add it to setup.py in the same way gevent has
been added earlier ?

Actually yes, we generally tend to avoid using the `requests` module as it was only added recently in Debian (stable), and we never need anything that the standard urllib/urllib2 cannot do.

So we've dropped that `requests` use in trunk rather than adding it to setup.py: addons rev.8842 rev-id: dle@xxxxxxxxxxx-20130802130349-206ms4c5s5dnzbti

Thanks for the heads up!


Follow ups

References