← Back to team overview

openerp-expert-localization team mailing list archive

Re: Modifications in base_vat

 

On Tuesday 03 August 2010, Luis Falcon wrote:
> Dear team
> 
> I have made some changes to the logic of base_vat, so we have more control
> of how and when to verify the VAT code.
> 
> The problem was that before we had to prepend the two letter ISO code of
> the country in order to get the verification. That was a problem, since
> every single method/function I had to create it had to strip the two first
> chars. On the other side, it also created a problem on imports. If your
> country was not among the ones with a VAT verification method, it would
> trigger the constraint.
> 
> So, to get rid of that and optimize the module, here are the changes /
> extra functionality :
> 
> - The VAT is calculated depending on the country.
> - No need to insert the two letter code in the VAT number, since it's not
> part of it anyways. Now the function will be calculated from the country
> code taken from the VAT country name
> - Added a verification flag, so you can avoid the verification if you want.
> - Change the name of the file "base_vat_data.xml" to "base_vat_view.xml"
> 
> 
> I committed two branches :
> 
> lp:~openerp-community/openobject-addons/meanmicio_base_vat (for
> improvements on base_vat )
> lp:~openerp-community/openobject-addons/meanmicio_fixes_5.0  ( for bugfixes
> on current release )
> 
> In the latter, I fixed the United Kingdom country ISO code ( UK -> GB ).
> 
> Hope you find it useful. Once tested, I will propose a merge.


This has already been implemented here:

commit 88af3786ebe5ad8a8da1560a334f2de081628282
Author: P. Christeas <p_christ@xxxxxx>
Date:   Tue May 25 19:43:37 2010 +0300

    [Bug 567216] Configure base_vat validation upon country
    
    Auto-select the VAT country (if not given in num) from partner or
    partner's company. Then, allow some countries to have non-validated
    numbers.




References