openerp-expert-production team mailing list archive

["Olivier Dony \(OpenERP\)" <528320@xxxxxxxxxxxxxxxxxx>]

Comment about the proposed patch: functionally it seems correct to me, but technically why not use the existing test_cancel() method that exists for this purpose, instead of adding one more method with the same code? 
Even better, why not wrap the existing test_cancel() method in a check_cancel() method that calls it and raises an error when it can't be cancelled. So instead of having a button that does nothing users would see a meaningful message?

-- 
[stock] picking cancels done moves (5.0)
https://bugs.launchpad.net/bugs/528320
You received this bug notification because you are a member of OpenERP
Manufacturing Experts, which is a direct subscriber.

Status in OpenObject Addons Modules: Confirmed

Bug description:
Hi!
5.0 latest bzr.
When a picking is cancelled, it cancels all moves, even if the moves are in done state. 'done' moves should never be altered.

Test case:
A picking with 3 moves. 2 of them are assigned, 1 is only confirmed because it doesn't have enough stock. Make the picking done and write the originally requested amount for move 3 instead of 0 in the partial picking wizard. Force the picking. 
Now there are 2 done lines and an assigned line. The stock worker changes his mind and cancels the picking. All 3 lines become cancelled.

Fix is provided in the attached patch.