openerp-india team mailing list archive

[Javier Duran - Vauxoo <812540@xxxxxxxxxxxxxxxxxx>]

@ Bogdan Stanciu,

Hi,

Check this please:
https://code.launchpad.net/~vauxoo/openobject-addons/REF-account_voucher/+merge/78747

** Changed in: openobject-addons
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/812540

Title:
  (account_voucher) action_move_line_create refactoring

Status in OpenERP Addons (modules):
  Fix Committed

Bug description:
  Version: 6.0
  Addons:
  revno: 4715
  revision-id: launchpad_translations_on_behalf_of_openerp-20110718051317-5w1lj4e12edvvqv7
  Module: account_voucher
  arch: account_voucher.py

  Hi,

  I think IMHO the action_move_line_create method need refactoring, it is too long and pretty
  confused, it has over 160 lines also there is a variable that doesn't follow the OpenERP Specific Guidelines
  (e.g. inv when you talk about voucher). I attached a patch file where this one
  becomes six smaller methods easier to understand and to use and to improve by others. I hope this can help
  a little to has a better readable/maintainable code.

  Regards,

  http://doc.openerp.com/v6.0/contribute/15_guidelines/coding_guidelines_framework.html
  http://doc.openerp.com/v6.0/contribute/15_guidelines/coding_guidelines_framework.html#call-your-fish-a-fish
  http://doc.openerp.com/v6.0/contribute/15_guidelines/coding_guidelines_framework.html#keep-your-methods-short-simple-when-possible

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/812540/+subscriptions