openerp-india team mailing list archive

[Raphaël Valyi - http://www.akretion.com <724131@xxxxxxxxxxxxxxxxxx>]

Hello Quentin,


sorry, I have one last little objection with the current code:

You here defined the following method:
def prepare_inv_line(self, cr, uid, account_id, order_line, context=None)

But in other parts of the code, we rather defined such methods with an underscore prefix such as:
_prepare_inv_line(self, cr, uid, account_id, order_line, context=None)

the reason we did that is because we expect arguments such as order_line
which are non RPC serializable primitive objects but server specific
"browse" objects. By adding an underscore we avoid to expose those
methods as an RPC webservice.

I would expect you would have followed the same convention here. Or else
if it's not a good one, let's rework the other such methods to make it
consistent.

What do you think?

** Changed in: openobject-addons
       Status: Fix Released => Confirmed

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/724131

Title:
  Purchase lines without Invoice Lines Relationship

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Hello,

  Using branch addons-6.0 revision number: 4422

  I created a purchase order, but the relationship between purchase
  order line and invoice line does not exist, the field
  purchase.order.line.invoice_lines is always empty.

  Renato Lima - http://www.akretion.com

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/724131/+subscriptions