← Back to team overview

openerp-india team mailing list archive

[Bug 882036] Re: Incorrect float rounding when setting float field with too high precision

 

We're lucky Python's "round" already implements those stuff for us :)

I've build a test that check if the rounding function works for the
algorithm you provided (i've used log2, seems to run a little faster) -
and, most importantly fails when provided any of the previous
algorithms.

http://pastebin.com/ZMHqyC0e

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/882036

Title:
  Incorrect float rounding when setting float field with too high
  precision

Status in OpenERP GTK Client:
  Confirmed
Status in OpenERP Server:
  Confirmed
Status in OpenERP Server 6.0 series:
  Confirmed

Bug description:
  Concerns 6.0 and trunk.
  If you define a precision of 0.01, the rounding of 0.125 must be 0.13 and not 0.12. The error is in the call of the format string "%.2f"%val which introduces a mathematical error. The round function must be called to apply the correct rounding before formatting the string. It should be:
  "%.2f"%round(val*100)/100
  Fix class digits_change of class float in the server. BUT fix also the gtk client AND web client as they all have that error (I let you find the right line)

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-client/+bug/882036/+subscriptions


References