← Back to team overview

openerp-india team mailing list archive

[Bug 794412] Re: delivery order with back order (after manual split) is wrongly indicated as 100% picked

 

Hi Patrick,

As indicated on your other bug 796320 I think this one needs a
workaround right now, as it is a source of mistakes that the user cannot
easily detect or fix manually.

Your patch is not correct however, because the procurement module does
not depend on the 'sale' module, and should thus not depend on
'sale.order.line' etc. The suggested patch in Rohan's merge proposal was
not correct either, namely because it only corrected the 'picked rate'
and not the 'shipped' flag, so only partially covered the issue.

I suggest to apply a mix of both as the workaround: we need to correct
the workflow test (and thus check_move_done()), but this needs to be
done within the sale module, not the procurement module. (I'm reopening
the bug so we do that)

Thanks for your well-documented bug reports!

** Changed in: openobject-addons
   Importance: Wishlist => Low

** Changed in: openobject-addons
       Status: Won't Fix => Confirmed

** Changed in: openobject-addons
    Milestone: None => 6.1

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/794412

Title:
  delivery order with back order (after manual split) is wrongly
  indicated as 100% picked

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Hey,
  When we do a partial picking for a delivery order, if we pick the corresponding original stock.move (the one which is linked to procurement.order), the procurement.order workflow terminates and the picking status of sale order is set to 100%.

  This is simply caused by the
  procurement>action_check_finished>check_move_done function which check
  the end of procurement.order workflow by looking only at original
  stock.move, not taking care of back order stock moves.

  Here is how to reproduce the bug:

  Create a Sale Order, with one order line (CPU1 - 10) from stock. Validate.
  In Delivery Order, split the stock move by assigning a production lot > prodlot: A, qty: 3
  Process the Delivery Order, and put 0 as a quantity for the prodlot A.
  A back order is created for prodlot A.
  The other 7 CPU1 are Done.
  Go to Sale Order, it is 100% picked. Procurement.order is Done.

  We want the picking state to take into account back orders, and
  therefore the procurement.order should not be Done until all related
  stock.moves are Done (or cancel).

  I use openerp 6.0.2. The behavior should be the same on the trunk
  version, as the check_move_done function is still the same.

  A proposal of correction, taking into account the moves linked to sale
  order lines instead of moves linked to procurement order is linked as
  attachment. The case where no sale order is involved (from order point
  ?) should be analyzed.

  Best,
  Patrick

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/794412/+subscriptions