openerp-india team mailing list archive

["Olivier Dony \(OpenERP\)" <922621@xxxxxxxxxxxxxxxxxx>]

You could do it with a simple CASE in the SQL query, but you need the value of the "account_account.currency_id" column, which may not be currently included in the query - so a bit of refactoring may be needed.
Something like:
    'foreign_balance': "CASE WHEN account_account.currency_id is NULL THEN 0 ELSE COALESCE(SUM(l.amount_currency), 0) END as foreign_balance"

It's not currently used in P&L, but only in the special "Unrealized Gain or Loss" report in Multi-Currency reports.
It could be added in P&L for information purpose, but only for accounts with secondary currencies.

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/922621

Title:
  [trunk] foreign_balance should not be computed for account with no
  secondary currency

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Hello.

  We are working on this Optimization:

  https://code.launchpad.net/~vauxoo/openobject-addons/trunk-bug_887376
  -account_compute_with_btree-VAUXOO/+merge/89741

  And we face a BIG problem with multicurrency feature just improved
  some little time ago.

  In this line of account.py

  'foreign_balance': "COALESCE(SUM(l.amount_currency), 0) as
  foreign_balance",

  We see that this algorithm sum all multicurrency values and it is
  TOTALLY wrong, because i can have n the same account different vaules,
  and we NEVER can sum Apples with Pears.

  How functionally you can try:

  Make an move invoice on €.
  Then Make an invoice to same partner in USD$
  Make an invoice an you currency, (We Use VEF).

  Then go to edit tree view for accounts and show the field
  "foreign_balance" with the view editor,

  You can face that if pfor example you made 3 invoice for 100 CURRENCY,
  the total for the account REceivable or Payable related on this
  invoices.

  The amount received is 300 (sum directly for 100€ 100$ and 100VEF)

  -In V6 this feature is simply missing.-

  I think it is a huge cancept mistake.

  IMHO, we need to have from OpenERP-dev team a Blueprint related with
  the concept that they want to implement in this field, because in
  other way this field is really useless and affect the performance in
  calculation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/922621/+subscriptions