openerp-india team mailing list archive

["Olivier Dony \(OpenERP\)" <934242@xxxxxxxxxxxxxxxxxx>]

Hello,

Having the auto-email notification enabled by default is a design choice and in fact the only sensible choice for new users. This is simply the natural behavior and having to look for such a feature would be a real usability issue.
Those automatic notifications are only sent when a document is confirmed, not when simply writing draft documents.
However we completely understand that some companies would like to customize them or turn them off, so that is why we included several mechanisms to do so:

- OpenERP setups without a proper Outgoing Email Server (SMTP) setup  will not be able to send out any email, and this will presumably be the case when testing (all demo partners are opted-out BTW)
- Customers without an email address will obviously not receive any notification (this will presumably be the case when testing, or perhaps they would have test emails instead)
- Customer who have been opted out will never receive notifications
- Finally, you can not only customize the templates but you can also delete them completely or remove the binding of the action for sending them from the corresponding workflow - and that is *permanent*

So yes, we have defined the templates and the action bindings in
NOUPDATE blocks from the very beginning - just look 25 lines below the
places in the code you mentioned, and you will see very obvious comments
about this[1], e.g.:

    <!-- Mail template and workflow bindings are done in a NOUPDATE block
         so users can freely customize/delete them -->

Deleting the action itself is unnecessary and would actually make it
harder to re-enable the feature later. Instead the cleanest thing to do
is to remove the action bindings from the corresponding workflow
activities, and they won't be automatically re-installed. *And* you can
easily re-bind them later as needed.

As for non-technical OpenERP users who don't know how to customize
workflows, they can simply opt-out customers or delete the templates
altogether - much easier than having to find an action to delete.


[1] http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/view/head:/account/edi/invoice_action_data.xml#L29


** Changed in: openobject-addons
       Status: New => Opinion

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/934242

Title:
  EDI Auto-email should not be active by default

Status in OpenERP Addons (modules):
  Opinion

Bug description:
  Hello,

  3 emails actions are created when we install the modules sale / account / purchase :
  Auto-email confirmed sale orders [1]
  Auto-email confirmed invoices [2]
  Auto-email confirmed purchase orders [3]

  These actions are configured to send a mail to the partners (unless if
  they have the "opt-out" on) with the document with the EDI system.

  I think that it is quite debatable to activate this by default. 
  In my opinion, this should be set off by default, and afterwards it should be the responsibility of the integrator or user to active this feature or not, because it can have serious effects on the customer base.

  But above all, noupdate="1" must be set on the xml! If you deactivate
  the actions server manually, because you (absolutely) do not want
  those mails to be send to your customers, next time you update your
  modules, the server actions will be reactivated ! (and mails will be
  sent before you see it.)

  The question is not on the quality or goodness of this EDI feature,
  but that's about the control of the mail outputs.

  Thanks for your understanding on this topic.

  Guewen

  [1] http://bazaar.launchpad.net/~openerp/openobject-addons/6.1/view/head:/sale/edi/sale_order_action_data.xml#L5
  [2] http://bazaar.launchpad.net/~openerp/openobject-addons/6.1/view/head:/account/edi/invoice_action_data.xml#L5
  [3] http://bazaar.launchpad.net/~openerp/openobject-addons/6.1/view/head:/purchase/edi/purchase_order_action_data.xml#L5

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/934242/+subscriptions