← Back to team overview

openerp-india team mailing list archive

[Bug 794634] Re: [6.0] Incorrect permissions on hr.timesheet_sheet workflow causes multiple issues for normal employees

 

Landed on stable 6.0,
Revision ID: ach@xxxxxxxxxxx-20110906124126-8vrclzyhgsp7zucg 
Revision 4809 

** Changed in: openobject-addons/6.0
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/794634

Title:
  [6.0] Incorrect permissions on hr.timesheet_sheet workflow causes
  multiple issues for normal employees

Status in OpenERP Addons (modules):
  Fix Released
Status in OpenERP Addons 6.0 series:
  Fix Released

Bug description:
  As described in the comments of the bug, the root issue here is the fact that the NEW->DRAFT workflow transition is restricted to the HR Officer groups, whereas it should be allowed for any Employee. In fact the second transition DRAFT->CONFIRM should also be allowed for any Employee, as it is the proper way to submit your own timesheet to your manager for approval.
  The group restriction on these transitions should be adapted accordingly.

  
  ====== original description below ====== 

  Hi,

  When clicking on My Timesheet menu entry, a new timesheet is created,
  even if a timesheet already exists for the current week.

  How to reproduce:
  - openerp 6.0 series with demo data
  - login with fbs/fbs
  - go to Human Resources / Time Tracking / My Timesheet
  - save the new timesheet
  - go to Human Resources / Time Tracking / My Timesheet agin
  - save the timesheet
  - error: Error occurred while validating the field(s) date_from,date_to: You can not have 2 timesheets that overlaps !
  Please use the menu 'My Current Timesheet' to avoid this problem.

  IMO, this is due to a fact that the query for existing timesheet
  filters on (state='draft'). This filter on state should be removed.

  Proposed patch attached.

  Best regards,

  -sbi

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/794634/+subscriptions