openerp-india team mailing list archive

["Amit Parik \(OpenERP\)" <amp@xxxxxxxxxxx>]

Hello Nicolas,

Thanks for the reply and I agree with you the problem will fix from the
addons side.

The problem occurs because of the on_change behaviour of webclient. The fact that web client will call on_change in cascade e.g. if result of on_change set new field, call the on_change of that field to. GTK does not support cascading on_change, So it will not call the other on_change.
 
On GTK when changing  product, onchange_product returns an account, uom, and tax for the product, and nothing else happens
Here on web when change product it returns the same, but then the onchange_product is called again because uom was changed by previous result, and onchange_account is called too and 2 onchange calls happen *in parallel* at the same time, because web is multi-threaded. onchange_product will only return the taxes of the product, but onchange_account will do the same *and then* add the taxes of the account.

So we have to improve the account_change from addons side like add this code.
unique_tax_ids = product_change_result['value']['invoice_line_tax_id'] instead of  unique_tax_ids |= set(product_change_result['value']['invoice_line_tax_id']) which will solved this problem.

So it's not a bug in web, but rather an inconsistency in addons. When
the account_change called from product _change or manually  product tax
should be overrides the account tax if product tax is assigned.

@fgi: This bug is not related to the fiscal position that's why I am
changing the title according to bug.

Note:If we have assigned a different taxes on our default tax on account
and product tax (sale tax on product) . The final expected tax is the
product tax if there is one set on the product, and if there is no
product tax, then we expect the tax of the account. (basically the
product tax overrides the account tax).

Thank you!

** Summary changed:

- Problem of taxes computing for fiscal positions
+ Account_change should be override the product tax to account tax if product tax assigned on product

** Changed in: openobject-addons
     Assignee: (unassigned) => OpenERP R&D Addons Team 3 (openerp-dev-addons3)

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/960158

Title:
  Account_change should be override the product tax to account tax if
  product tax assigned on product

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Context: web client, Windows 7, OpenERP 6.1

  Modules installed: Sales, Purchase with Generic chat of account, tax
  15%

  When a create a sale order for a product with a default tax (ex: ITAX
  R) and when I associate this sale order to a customer who has the
  basic "Normal taxes" fiscal position (without change from the basic
  empty database), I get an invoice which only provides that product tax
  (ITAX R). That is correct, because the "Normal taxes" fiscal position
  only modifies the tax "Tax 15%", and replaces it by "Purchases tax
  15%".

  However, when I directly create the invoice for the same product and
  the same customer, OpenERP add the "Purchases tax 15%" to the ITAX R.
  So I get two taxes why I only expect the second one. Here is an
  important error I guess.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/960158/+subscriptions