← Back to team overview

openerp-india team mailing list archive

[Bug 999103] Re: [trunk] mrp_bom._bom_find: unused argument product_uom

 

Hello Alexandre,

You got me wrong .Let me explain further

As you said method called  _bom_find(self, cr, uid, product_id,
product_uom, properties=[])  has a argument product_uom , which is not
used .

But when this method is called again in method    def action_compute()
at line 604(trunk), which is computing all bom for that product... at
line 621

 >>>     bom_id = bom_obj._bom_find(cr, uid, production.product_id.id,
production.product_uom.id, properties)

Secondly  In method  def _bom_explode() at line no 318 this method is
called further for finding bom's product which is used for write work
center


 if bom.type == 'phantom' and not bom.bom_lines:
>>>     newbom = self._bom_find(cr, uid, bom.product_id.id, bom.product_uom.id, properties)

 if newbom:
                res = self._bom_explode(cr, uid, self.browse(cr, uid, [newbom])[0], factor*bom.product_qty, properties, addthis=True, level=level+10)


 Hope this will clear to you

Thanks..!!

** Changed in: openobject-addons
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/999103

Title:
  [trunk] mrp_bom._bom_find: unused argument product_uom

Status in OpenERP Addons (modules):
  Incomplete

Bug description:
  The signature of mrp_bom._bom_find has a product_uom parameter which
  is not used. I think it should be deprecated and removed altogether.
  At the very least the docstring should be fixed to say that the
  argument is ignored, but I believe some code could be simplified and
  made clearer by removing that argument recursively accross the call
  stack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/999103/+subscriptions


References