openerp-india team mailing list archive

["Alexandre Fayolle @ camptocamp" <alexandre.fayolle@xxxxxxxxxxxxxx>]

Hi Ravish,

What I'm proposing is that in trunk
* the argument product_uom  is removed from _bom_find
* the docstring is updated
* all calls to _bom_find are updated to not pass the product_uom argument

This will:

* simplify the code of people calling _bom_find
* reduce confusion for people reading the code and trying to figure out how the parameter is used only to find out that it is not used despite what the docstring says. 

** Changed in: openobject-addons
       Status: Incomplete => New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/999103

Title:
  [trunk] mrp_bom._bom_find: unused argument product_uom

Status in OpenERP Addons (modules):
  New

Bug description:
  The signature of mrp_bom._bom_find has a product_uom parameter which
  is not used. I think it should be deprecated and removed altogether.
  At the very least the docstring should be fixed to say that the
  argument is ignored, but I believe some code could be simplified and
  made clearer by removing that argument recursively accross the call
  stack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/999103/+subscriptions