openerp-india team mailing list archive

["Amit Parik \(OpenERP\)" <amp@xxxxxxxxxxx>]

Hello Alexandre,

Yes, you are right we have passed the product_uom parameter on _bom_find
method but we didn't used this argument under this function.

But what ravish is said, we have called this method many times under
some function at there we have used this argument. Just check line#565
on mrp.py under  product_id_change we have called  _bom_find method at
there sticky needed this argument also it need on some other method . So
we can not remove this argument.

IF we have to remove this parameter then we must update all place at
where this function is called, I don't think it's good.

So this is not a bug and I am closing this issue.

Thanks for understanding!

** Changed in: openobject-addons
       Status: New => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/999103

Title:
  [trunk] mrp_bom._bom_find: unused argument product_uom

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  The signature of mrp_bom._bom_find has a product_uom parameter which
  is not used. I think it should be deprecated and removed altogether.
  At the very least the docstring should be fixed to say that the
  argument is ignored, but I believe some code could be simplified and
  made clearer by removing that argument recursively accross the call
  stack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/999103/+subscriptions