← Back to team overview

openerp-india team mailing list archive

[Bug 993414] Re: Bad file permissions and EOL encodings

 

Hello Alec,

You are absolutely right, there are many files has a  bad permission on
addons and server.

I have checked this with  find . -type f -perm -001 -ls command and found such kinds of file.
i.e 14687313    4 -rwxrwxrwx   1 amp      amp          1511 Apr  6 10:35 ./purchase_double_validation/test/purchase_double_validation_test.yml
14690566    4 -rwxr-xr-x   1 amp      amp           744 May 17 15:52 ./l10n_fr/l10n_fr_view.xml
14690576    4 -rwxr-xr-x   1 amp      amp          3014 May 17 15:52 ./l10n_fr_hr_payroll/report/fiche_paye.py
14690572   60 -rwxr-xr-x   1 amp      amp         57762 May 17 15:52 ./l10n_fr_hr_payroll/l10n_fr_hr_payroll_data.xml
14690573    4 -rwxr-xr-x   1 amp      amp          2585 May 17 15:52 ./l10n_fr_hr_payroll/l10n_fr_hr_payroll_view.xml
14690569    4 -rwxr-xr-x   1 amp      amp          1086 May 17 15:52 ./l10n_fr_hr_payroll/__init__.py
14690571    4 -rwxr-xr-x   1 amp      amp          2084 May 17 15:52 ./l10n_fr_hr_payroll/l10n_fr_hr_payroll.py
14690570    4 -rwxr-xr-x   1 amp      amp          2047 May 17 15:52 ./l10n_fr_hr_payroll/__openerp__.py
14685161   16 -rwxrwxrwx   1 amp      amp         14451 Mar 20 13:57 ./email_template/html2text.py
14814897    4 -rwxrwxrwx   1 amp      amp            57 Mar 20 13:57 ./plugin_thunderbird/static/thunderbird_plugin/install.sh
14685749    4 -rwxrwxrwx   1 amp      amp          1553 Mar 20 13:57 ./document/test_cindex.py
14685319    4 -rwxrwxrwx   1 amp      amp          2113 Mar 20 13:57 ./document/odt2txt.py
14814335  116 -rwxrwxrwx   1 amp      amp        116090 Mar 20 13:57 ./document_ftp/ftpserver/ftpserver.py
14815791    4 -rwxrwxrwx   1 amp      amp            65 Mar 20 13:57 ./base_report_designer/plugin/openerp_report_designer/bin/OOo_run.sh
14814972    4 -rwxrwxrwx   1 amp      amp          1319 Mar 20 13:57 ./account_asset/security/ir.model.access.csv
14811883    4 -rwxrwxrwx   1 amp      amp          1122 Mar 20 13:57 ./account_asset/wizard/__init__.py
14817509    8 -rwxrwxrwx   1 amp      amp          6021 Mar 20 13:57 ./account_asset/wizard/account_asset_change_duration.py
14817507    4 -rwxrwxrwx   1 amp      amp          2526 Mar 20 13:57 ./account_asset/wizard/wizard_asset_compute.py
18226614   32 -rwxrwxrwx   1 amp      amp         29417 May 12 13:48 ./account_asset/i18n/de.po
18226627   28 -rwxrwxrwx   1 amp      amp         25414 May 12 13:48 ./account_asset/i18n/pl.po
14814304   16 -rwxrwxrwx   1 amp      amp         12686 Mar 20 13:57 ./account_asset/i18n/fr_BE.po
18226628   32 -rwxrwxrwx   1 amp      amp         30010 May 12 13:48 ./account_asset/i18n/pt.po
14690985   32 -rwxrwxrwx   1 amp      amp         28901 May 25 10:05 ./account_asset/i18n/fr.po
18226611   28 -rwxrwxrwx   1 amp      amp         25388 May 12 13:48 ./account_asset/i18n/ca.po
18226615   32 -rwxrwxrwx   1 amp      amp         30102 May 12 13:48 ./account_asset/i18n/es.po
18226617   32 -rwxrwxrwx   1 amp      amp         30123 May 12 13:48 ./account_asset/i18n/es_CR.po
18226633   24 -rwxrwxrwx   1 amp      amp         21098 May 12 13:48 ./account_asset/i18n/sv.po
14685750   28 -rwxrwxrwx   1 amp      amp         27941 Mar 20 13:57 ./document_webdav/test_davclient.py
14943245  120 -rwxrwxrwx   1 amp      amp        122561 Mar 20 13:57 ./wiki/web/widgets/rss/feedparser.py
14943555    4 -rwxrwxrwx   1 amp      amp           765 Mar 20 13:57 ./wiki/static/src/lib/wiky/input_complete
14943663   72 -rwxrwxrwx   1 amp      amp         72739 Mar 20 13:57 ./wiki/static/src/lib/wiky/jquery-1.4.2.min.js
14944249    4 -rwxrwxrwx   1 amp      amp           871 Mar 20 13:57 ./wiki/static/src/lib/wiky/Readme.md
14942592    4 -rwxrwxrwx   1 amp      amp            93 Mar 20 13:57 ./wiki/static/src/lib/wiky/autogit.sh
14944920    8 -rwxrwxrwx   1 amp      amp          7438 Mar 20 13:57 ./wiki/static/src/lib/wiky/wiky.js
14943554    4 -rwxrwxrwx   1 amp      amp          1655 Mar 20 13:57 ./wiki/static/src/lib/wiky/index.html
14944919    4 -rwxrwxrwx   1 amp      amp          1872 Mar 20 13:57 ./wiki/static/src/lib/wiky/wiky.css
14944241    4 -rwxrwxrwx   1 amp      amp           307 Mar 20 13:57 ./purchase_requisition/test/purchase_requisition_demo.yml
14817150    4 -rwxrwxrwx   1 amp      amp           191 Mar 20 13:57 ./l10n_ch/test/test_part_2.v11
14817149    4 -rwxrwxrwx   1 amp      amp           191 Mar 20 13:57 ./l10n_ch/test/test_part_1.v11
14817120    4 -rwxrwxrwx   1 amp      amp           191 Mar 20 13:57 ./l10n_ch/test/test.v11
14815787   40 -rwxrwxrwx   1 amp      amp         40312 Mar 20 13:57 ./l10n_ch/report/ocrbb.ttf
14815797    8 -rwxrwxrwx   1 amp      amp          7567 Mar 20 13:57 ./mail/static/scripts/openerp_mailgate.py


13637965    4 -rwxrwxrwx   1 amp      amp           562 Mar 20 14:20 ./bin/openerp-server.py
14946073    4 -rwxrwxrwx   1 amp      amp           254 Mar 20 14:20 ./history/list-services.sh
14945961    4 -rwxrwxrwx   1 amp      amp           453 Mar 20 14:20 ./history/change-loglevel.sh
14946024    4 -rwxrwxrwx   1 amp      amp           298 Mar 20 14:20 ./history/get-srvstats.sh
14946242    4 -rwxrwxrwx   1 amp      amp          3060 Mar 20 14:20 ./history/module_graph.py
14946299    4 -rwxrwxrwx   1 amp      amp          1384 Mar 20 14:20 ./history/gen_graph.sh
13245664   12 -rwxrwxrwx   1 amp      amp          9763 Apr  2 15:27 ./openerp-server
14945885   16 -rwxrwxrwx   1 amp      amp         16139 Mar 20 14:20 ./openerp/addons/base/res/config_pixmaps/2.png
14945886   16 -rwxrwxrwx   1 amp      amp         13916 Mar 20 14:20 ./openerp/addons/base/res/config_pixmaps/3.png
14945884   20 -rwxrwxrwx   1 amp      amp         19440 Mar 20 14:20 ./openerp/addons/base/res/config_pixmaps/1.png
14945942   16 -rwxrwxrwx   1 amp      amp         14751 Mar 20 14:20 ./openerp/addons/base_quality_interrogation.py
14946171   20 -rwxrwxrwx   1 amp      amp         17786 Mar 20 14:20 ./openerp/report/render/rml2txt/rml2txt.py
15337145   28 -rwxrwxrwx   1 amp      amp         26386 Mar 23 10:06 ./openerp/tools/graph.py
14946371    4 -rwxrwxrwx   1 amp      amp           432 Mar 20 14:20 ./openerp/tools/test-config-values
14946403    8 -rwxrwxrwx   1 amp      amp          6884 Mar 20 14:20 ./openerp/tools/which.py
14946175    4 -rwxrwxrwx   1 amp      amp           616 Mar 20 14:20 ./debian/rules
13506090    8 -rwxrwxrwx   1 amp      amp          4482 Mar 20 14:20 ./setup.py


Also we can check this file's wrong permission to another way check the properties of this file and Open the "Permission"  tab.See "allow executing file as a program" is a True, As per my point of view, It will create a problem on .deb packages.

So as a generalise way I am assigning this to Framework team.

Thank you!

** Changed in: openobject-server
   Importance: Undecided => Low

** Changed in: openobject-server
       Status: New => Confirmed

** Changed in: openobject-server
     Assignee: (unassigned) => OpenERP's Framework R&D (openerp-dev-framework)

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/993414

Title:
  Bad file permissions and EOL encodings

Status in OpenERP Server:
  Confirmed

Bug description:
  A lot of the files in the overall project  has random file
  permissions. In a packaging context, something like this is needed to
  rectify:

  find . -name \*.py -a -perm 644 | \
      xargs sed -i -e '\;/usr/bin/env;d' -e '\;/usr/bin/python;d'
  find . -name \*.html -o -name \*yml -o -name \*.js -o -name \*.po  \
      -o -name \*.css -o -iname readme* -o -name \*.csv \
      -o -name account_asset_change_duration.py \
      -o -name base_quality_interrogation.py |
          xargs chmod 644
  chmod 644 $( find openerp/addons/account_asset -name \*.py )
  chmod 644       openerp/addons/l10n_ch/test/test*.v11

  Also, some files have DOS eol encodings, as opposed to the overall
  Unix/Linus conventions. To fix:

  find . -name \*.html | xargs sed -i 's/\r//'
  sed -i 's/\r//' openerp/addons/l10n_ch/test/test*.v11
  sed -i 's/\r//' openerp/addons/account_asset/security/ir.model.access.csv

  Packaging would be simpler something like these command were applied
  to the source

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/993414/+subscriptions


References