← Back to team overview

openerp-india team mailing list archive

Re: [Bug 1023615] Re: Module upgrade ignores noupdate attribute for deleted records

 

I have created the https://bugs.launchpad.net/openobject-server/+bug/1024114
The 980369 was reported as a security issue (whereI believe it belongs to),
with the hope this mark should improve the reaction. But I have checked
now, it is marked with a restricted visibility, with exactly the opposite
result (nobody sees the problem...)
Let's see if something happens...

2012/7/12 Don Kirkby <1023615@xxxxxxxxxxxxxxxxxx>

> Can you check that bug number, Gustavo? I can't find any bug 980369 on the
> server project or the addons project. If you can't find the bug, why don't
> you create a new one with detailed steps to reproduce it and include your
> patch there?
> I think our chances of getting two small bugs fixed are better than if we
> combine the CSV bug into this deleted records bug.
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Server.
> https://bugs.launchpad.net/bugs/1023615
>
> Title:
>   Module upgrade ignores noupdate attribute for deleted records
>
> Status in OpenERP Server:
>   Confirmed
>
> Bug description:
>   If I delete one of a module's standard configuration records, then
>   upgrading the module recreates that record. This happens even when the
>   noupdate attribute has been set. For example, when I delete a unit of
>   measure, it comes back.
>
>   I suspect this may have been a design change in v6.0 instead of a bug.
>   If that's true, will I cause myself problems by changing it back? Was
>   there a reason for the change, or did some users just prefer the new
>   behaviour?
>
>   Steps to reproduce:
>   1. Create a blank database with no demo data using version 6.1.1.
>   2. From the Settings menu, choose Modules: Modules.
>   3. Turn off the Apps filter and install the product module.
>   4. From the Settings menu, choose Users: Users.
>   5. Open the admin user and go to the Access Rights tab.
>   6. Set the Sales Management level to Manager, and turn on the Extended
> View.
>   7. Reload the main menu. From the Sales menu, choose Configuration:
> Products: Units of Measure: Units of Measure.
>   8. Delete the "g" record.
>   9. Go back to the Modules screen and upgrade the product module.
>   10. Go back to the Units of Measure screen and click the Find button.
>
>   Expected behaviour: the "g" record should stay deleted because
> product_data.xml used noupdate="1".
>   Actual behaviour: the "g" record is recreated.
>
>   Workaround: instead of deleting the record, mark it inactive.
>
>   Impact:
>   There's no way for a user to tell whether a record is a standard
> configuration record or was added by a user, so they can't tell whether
> they're allowed to really delete it or they have to deactivate it. If I
> decide to live with the new behaviour, then I think I'll just have to tell
> the users not to delete any records from screens in the configuration
> menus. I guess that's probably a good policy anyway, because they can't
> easily tell whether it's being referenced by any child records.
>   Where it's really biting us, though, is the migration process from
> version 5.0 to 6.0. Any records that we deleted, like currencies, are
> unexpectedly reappearing and causing errors.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-server/+bug/1023615/+subscriptions
>


--

Gustavo Adrian Marino

Mobile: +54 911 5498 2515

Email: gamarino@xxxxxxxxx

Skype: gustavo.adrian.marino

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/1023615

Title:
  Module upgrade ignores noupdate attribute for deleted records

Status in OpenERP Server:
  Confirmed

Bug description:
  If I delete one of a module's standard configuration records, then
  upgrading the module recreates that record. This happens even when the
  noupdate attribute has been set. For example, when I delete a unit of
  measure, it comes back.

  I suspect this may have been a design change in v6.0 instead of a bug.
  If that's true, will I cause myself problems by changing it back? Was
  there a reason for the change, or did some users just prefer the new
  behaviour?

  Steps to reproduce:
  1. Create a blank database with no demo data using version 6.1.1.
  2. From the Settings menu, choose Modules: Modules.
  3. Turn off the Apps filter and install the product module.
  4. From the Settings menu, choose Users: Users.
  5. Open the admin user and go to the Access Rights tab.
  6. Set the Sales Management level to Manager, and turn on the Extended View.
  7. Reload the main menu. From the Sales menu, choose Configuration: Products: Units of Measure: Units of Measure.
  8. Delete the "g" record.
  9. Go back to the Modules screen and upgrade the product module.
  10. Go back to the Units of Measure screen and click the Find button.

  Expected behaviour: the "g" record should stay deleted because product_data.xml used noupdate="1".
  Actual behaviour: the "g" record is recreated.

  Workaround: instead of deleting the record, mark it inactive.

  Impact:
  There's no way for a user to tell whether a record is a standard configuration record or was added by a user, so they can't tell whether they're allowed to really delete it or they have to deactivate it. If I decide to live with the new behaviour, then I think I'll just have to tell the users not to delete any records from screens in the configuration menus. I guess that's probably a good policy anyway, because they can't easily tell whether it's being referenced by any child records.
  Where it's really biting us, though, is the migration process from version 5.0 to 6.0. Any records that we deleted, like currencies, are unexpectedly reappearing and causing errors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/1023615/+subscriptions


References