← Back to team overview

openerp-india team mailing list archive

[Bug 1024813] Re: base_iban module never validates BIC

 

Hello Tobias,

We have a m20 field bank on res.partner.bank object with relation
res.bank object. res.bank object has a BIC(bank identifier code or
business identifier code) and here at constraint we have used a bic
field of res,bank object not the bank_bic field of res.partner.bank
object.

Because if we have used a bank_bic field of res.partner.bank object then
this constraint will never raised because this constraint will raised
only when we have select bank account type = "iban account" see the
condition "if partner_bank.state == 'iban' "  and when we select iban
account in bank account type subsequently the bank_bic field will become
required , So we must have to fill it. And if we have filed this field,
So how can the constraint will fire. Cause just see the condition you
suggested "if partner_bank.state == 'iban' and not
partner_bank.bank_bic: ". And this condition never will be satisfied
(hope you will got this.),

Now comes to original code, if we will not not filled the bank(m2o
field)'s "Bank identifier code" then this error will simply raised. So
all are working fine right now.

I have attached a video for more reference, So would you please check
which will help you more.

Thanks for understanding!

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1024813

Title:
  base_iban module never validates BIC

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  I'm using OpenERP 6.1 and the base_iban module will never validate an
  IBAN account correctly. In line 144 of base_iban.py, it says

      if partner_bank.state == 'iban' and not partner_bank.bank.bic:

  when it should in fact say

      if partner_bank.state == 'iban' and not partner_bank.bank_bic:

  (note that the dot has been replaced by an underscore).

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1024813/+subscriptions


References