← Back to team overview

openerp-india team mailing list archive

[Bug 1043250] Re: Product is empty when creating invoices when billing tasks works

 

Hello,Damien

I have checked your issue. But in stable_6 if you make invoice from Project > invoice on task work. 
suppose ,you haven't set product in bill task form and also ignore in force product wizard(invoice analytical line) that time invoice line not setting with product from employee (time sheet tab) . So here also  invoice line is not linked to a product. and also If you not define type of invoice in bill task form  ,in this case product not set to invoice line.

If ,I made a mistake. Correct me. Waiting for reply..!!!


Thanks.!!


** Changed in: openobject-addons
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1043250

Title:
  Product is empty when creating invoices when billing tasks works

Status in OpenERP Addons (modules):
  Incomplete

Bug description:
  Hello,

  I constated the following bug in OpenERP 6.1:

  When you bill tasks works, you can force to use a specific product,
  but it's not obligatory. If you don't, the invoice lines created
  haven't any product.

  In OpenERP 6.0.2, there wasn't this bug, and the product was set from
  the employee, like I think it's true.

  After searching and debugging, I found this:in the file
  addons/hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py

  In the V6.0.2, you find the following code:

  curr_line = {
                      ...
                      'product_id': data['product'] or product_id,
                      
  If the dict contains a key 'product' and if it is not empty or False, it will take that (when we set a product to force to use). If it isn't set, it will take the product_id of the product set on the employee. It is true.

  
  In the V. 6.1, we find this code:

  curr_line = {
                      ...
                      'product_id': data.get('product',product_id),

  If the dict data doesn't contains a key product, will use product_id.
  But this is false, because when we don't set a product to force to
  use, data contains a key product, with the value False, and the
  invoice line curr_line is not linked to a product.

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1043250/+subscriptions


References