openerp-india team mailing list archive

[Houssine <1047525@xxxxxxxxxxxxxxxxxx>]

Hi Amit,

Thanks for you feedback!

Kind regards,
Houssine BAKKALI

On Mon, Sep 10, 2012 at 11:30 AM, Amit Parik (OpenERP)
<amp@xxxxxxxxxxx>wrote:

> Hello,
>
> I am assigning this to related author of the branch who can take the
> decision on it.
>
> Thank you!
>
> ** Changed in: openobject-addons
>      Assignee: (unassigned) => Luc De Meyer (Noviat) (luc-demeyer)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1047525
>
> Title:
>   account_pain module wrong currency check
>
> Status in OpenERP Addons (modules):
>   New
>
> Bug description:
>   Hi,
>
>   I've found a wrong currency check in in the pain_wizard.py file of the
>   account_pain module.
>
>   In the test described by the following code :
>
>         if payment.mode.journal.currency.name != 'EUR':
>                   raise osv.except_osv(_('Payment Order Error!'),
>                       _('Only payments from a EURO bank account are
> supported in the current release '   \
>                         'of the ISO 20022 payment module!'))
>
>   The test doens't take into account the company currency.
>
>   In fact, it just check if the currency 's journal is different of
>   'EUR' which should be always the case if the company currency is
>   'EUR'. As you can't define the same currency for an account that for
>   the company.
>
>   the test should take this into account reflect something like this
>
>   if company.currency_id.name != 'EUR':
>               if payment.mode.journal.currency.name != 'EUR':
>                   raise osv.except_osv(_('Payment Order Error!'),
>                       _('Only payments from a EURO bank account are
> supported in the current release '   \
>                         'of the ISO 20022 payment module!'))
>
>   Hope that this will help to improve this already excellent module!
>
>   Kinds Regards,
>   Houssine
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptions
>

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1047525

Title:
  account_pain module wrong currency check

Status in OpenERP Addons (modules):
  New

Bug description:
  Hi,

  I've found a wrong currency check in in the pain_wizard.py file of the
  account_pain module.

  In the test described by the following code :

        if payment.mode.journal.currency.name != 'EUR':
                  raise osv.except_osv(_('Payment Order Error!'),
                      _('Only payments from a EURO bank account are supported in the current release '   \
                        'of the ISO 20022 payment module!'))     

  The test doens't take into account the company currency.

  In fact, it just check if the currency 's journal is different of
  'EUR' which should be always the case if the company currency is
  'EUR'. As you can't define the same currency for an account that for
  the company.

  the test should take this into account reflect something like this

  if company.currency_id.name != 'EUR':
              if payment.mode.journal.currency.name != 'EUR':
                  raise osv.except_osv(_('Payment Order Error!'),
                      _('Only payments from a EURO bank account are supported in the current release '   \
                        'of the ISO 20022 payment module!'))   

  Hope that this will help to improve this already excellent module!

  Kinds Regards,
  Houssine

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptions