openerp-india team mailing list archive

["Alexandre Fayolle @ camptocamp" <alexandre.fayolle@xxxxxxxxxxxxxx>]

On lun. 17 sept. 2012 12:58:58 CEST, Rifakat (OpenERP) wrote:
> Hello Niels,
>
> It is very risky to change the method name for stable version. It may create problem
> for production users.
>
> Code has been improved and re-factored for partial picking wizard in 6.1 and trunk versions
> but for 6.0 we can not change it.

In this context, I'd daresay the risk is very low : it's a Python 
private method, which means that any code calling it is already doing 
some very dirty trick.

If you're concerned about breaking 3rd party code, follow the following 
path:

1. rename the method by removing 1 underscore
2. create a method with the old name which will call the new 
implementation.

--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1050957

Title:
  [6.0] stock: stock.partial.picking wizard has a function with '__'
  prefix which prevents inheritance

Status in OpenERP Addons (modules):
  Won't Fix

Bug description:
  http://bazaar.launchpad.net/~openerp/openobject-
  addons/6.0/view/head:/stock/wizard/stock_partial_picking.py#L119

  The function definition here uses the __ prefix which prevents
  inheritance in Python.

  This was already fixed in trunk and 6.1 code, please backport the fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1050957/+subscriptions