← Back to team overview

openerp-india team mailing list archive

[Bug 1023047] Re: can't add new work to task if there's already work for a confirm/done timesheet

 

Hello,

Follow the step for reproduce this Bug.

1. create two timesheet with different week.(one with open state and other with Waiting for Approve state)
2. Now create task work line.
3. Try to save this : warning occured

Expected Result : task should be link with the open timesheet. not
updating the old ones.

Also I have attached the video for brief Info.

Thanks! 
 

** Attachment added: "Screencast of Reproduce"
   https://bugs.launchpad.net/openobject-addons/+bug/1023047/+attachment/3340487/+files/hr_timesheet_NotlinktoTASK.ogv

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1023047

Title:
  can't add new work to task if there's already work for a confirm/done
  timesheet

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  OpenERP version is 6.1.1, with modules hr_timesheet_sheet and
  project_timesheet.

  Steps to reproduce:
  1) Create a timesheet for an employee
  2) Create a task and log some work, timesheet lines will be created (to have this working I had to apply the patch described in https://bugs.launchpad.net/openobject-addons/+bug/949078 )
  3) Submit the timesheet for approval
  4) Try to log more work on the task

  Observed result: I'm getting an error message that says that a
  timesheet line cannot be updated if the timesheet is confirm/done.

  Expected result: User should be able to add more work and new
  timesheet lines should be created, not updating the old ones that
  already belong to a confirm/done timesheet.

  Possible fix:
  To fix this issue I added this code in file project_timesheet.py, inside write function for class project_work:

              if line_id.sheet_id.state in ['confirm','done']:
                  # ignore changes if timesheet is in confirm or done status
                  continue

  I added the lines inside the "for task" just after the line_id null
  verification. With this is now working for me.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1023047/+subscriptions


References