openerp-india team mailing list archive

["Amit Bhavsar \(Open ERP\)" <1075908@xxxxxxxxxxxxxxxxxx>]

Hello Jacara,

It's already Improve in trunk. So I am closing this Issue.

Thanks!

** Changed in: openobject-addons
       Status: New => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1075908

Title:
  Some code seems HARD CODING way

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  Hello

  I think there is some HARD CODING issues on account module. See
  addons/account/account.py line 3336:

  ir_values_obj.set(cr, 1, key='default', key2=False, name="taxes_id", company=company_id,
                                  models =[('product.product',False)], value=[taxes_ref[obj_wizard.sale_tax.id]])

  super user id must be 1. However it is  a HARD CODE.
  Right usage: 
  from openerp import SUPERUSER_ID
  ir_values_obj.set(cr, SUPERUSER_ID, key='default', key2=False, name="taxes_id", company=company_id,
                                  models =[('product.product',False)], value=[taxes_ref[obj_wizard.sale_tax.id]])

  I don't know how many usage of super user codes exists. I know it is
  not dangerous but wrong.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1075908/+subscriptions