← Back to team overview

openerp-india team mailing list archive

[Bug 1076945] Re: sale tab and procurement tab should be invisible depending on purchase_ok and sale_ok

 

Hello,

In latest trunk, there are some filtering rules applied on the products,
if you go to sales > products, it will by default apply the filter "Can
be sold" and on the contrary, in the purchase > product window, it will
apply the "Can be purchased" filter, so you only see the correct
products and you can decide to remove the filter if for any reason you
need to see the other category of products.

Therefore I'm closing this bug.

Thanks

** Changed in: openobject-addons
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1076945

Title:
  sale tab and procurement tab should be invisible depending on
  purchase_ok and sale_ok

Status in OpenERP Addons (modules):
  Fix Released

Bug description:
  This is a small usability concern:

  Products have a Tab for "Procurement" and a Tab for "Sale". 
  They also know if they can be purchased (with the ``purchase_ok`` boolean), and sold (with the ``sale_ok``).

  Why the "Sale" tab keeps showing on product that are not to be sold ?
  Why the "Procurement" tab keeps showing on product that are not to be purchased ?

  This should correct the behavior:

  diff --git a/product/product_view.xml b/product/product_view.xml
  index 028e416..ec3529c 100644
  --- a/product/product_view.xml
  +++ b/product/product_view.xml
  @@ -98,7 +98,7 @@
                                   </group>
                                   <field name="description" placeholder="describe the product's characteristics for internal use..."/>
                               </page>
  -                            <page string="Procurements" groups="base.group_user">
  +                            <page string="Procurements" groups="base.group_user" attrs="{'invisible': [('purchase_ok', '=', 0)]}">
                                   <group name="procurement">
                                       <group name="general">
                                           <field name="cost_method" groups="product.group_costing_method"/>
  @@ -124,7 +124,7 @@
                                       </group>
                                   </group>
                               </page>
  -                            <page string="Sales" attrs="{'readonly':[('sale_ok','=',0)]}">
  +                            <page string="Sales" attrs="{'readonly':[('sale_ok','=',0)], 'invisible': [('sale_ok', '=', 0)]}">
                                   <group name="sale">
                                       <group string="Sale Conditions">
                                           <label for="warranty"/>

  
  If this is not correct, please take the time to comment why. Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1076945/+subscriptions


References