openerp-india team mailing list archive

["Jose Antonio Morales Ponce\(vauxoo\)" <1083778@xxxxxxxxxxxxxxxxxx>]

Ok perfect, but it should change the variable declaration, because these
declaring a dictionary and then a string retainers, is a bad practice
and consume resources necesarion not declaring a mutable variable

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1083778

Title:
  Declared a variable of type dictionary and then try to do a + = with a
  variable of type string in the sale.order model

Status in OpenERP Addons (modules):
  New

Bug description:
  Declared a dictionary method product_id_change on line 905, then later try to do a + = with another type variable str, causing the following traceback:
  Traceback (most recent call last):
     File "<input>", line 1, in <module>
  TypeError: unsupported operand type (s) for + =: 'dict' and 'str'

  Error source:
  File: sale.py
  model: sale.order.line
  method: product_id_change

   905         warning_msgs = {}

   962 
   963         if not pricelist:
   964             warn_msg = _('You have to select a pricelist or a customer in the sales form !\n'
   965                     'Please set one before choosing a product.')
   966             warning_msgs += _("No Pricelist ! : ") + warn_msg +"\n\n"

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1083778/+subscriptions