← Back to team overview

openerp-india team mailing list archive

[Bug 1086396] Re: the process_email_queue scheduled task sends mail twice, on mass-mailing

 

Thanks for the detailed description! There's indeed a problem in the way
ir.cron expects to manager the transaction/cursor passed to jobs being
executed, and the common need for most jobs to perform batch isolated
transactions and thus commit them individually.

Perhaps ir.cron should pass yet another cursor to the jobs, one that may
be safely committed without releasing the cron lock. That would avoid
having to do that in every other job, and possibly forgetting about it,
leading to hard-to-diagnose errors.

If you agree on that, let's move the bug report to the server project
for now.

** Project changed: openobject-addons => openobject-server

** Changed in: openobject-server
   Importance: Undecided => High

** Changed in: openobject-server
       Status: New => Confirmed

** Changed in: openobject-server
     Assignee: (unassigned) => OpenERP's Framework R&D (openerp-dev-framework)

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/1086396

Title:
  the process_email_queue scheduled task sends mail twice, on mass-
  mailing

Status in OpenERP Server:
  Confirmed

Bug description:
  Hello,

  we discovered that the "mail" addon is sending some messages twice.

  This is because the cron task "commits" the cursor after each message,
  and it releases the lock which was acquired on "ir_cron" table.

    # Try to grab an exclusive lock on the job row from within the task transaction
    "SELECT * FROM ir_cron WHERE id=%s FOR UPDATE NOWAIT"

  So the same cron will be launched again without waiting the end of the
  previous one. and the "search" will grab some mail.messages which are
  already processed by the first job.

  We just sent some thousands of e-mails, and we had few of them which
  were sent twice.

  The fix should be simple: do not use the main cursor to send the
  e-mails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/1086396/+subscriptions


References