← Back to team overview

openerp-india team mailing list archive

[Bug 1082009] Re: HR > Leave Requests. User can write date fields of an already approved Leave Request

 

Hello,

Thanks for your intervention Amit !  After a review with al, fp and qdp, the behavior of the hr_holidays' calendar view seems ok to us: 
- any administrator, hr officier or hr manager can move a confirmed leave request anywhere, which is normal.
- any other user (hr employee) won't be able to do so: drag'n'dropping the request somewhere else will result in an error.  This behavior has been introduced by fp's merge, revno 7969, which overrides the write() method of hr_holidays.

That beeing, as you said, read only values should prevent a leave request from beeing moved in such cases (gantt and calendar views).  Moreover, it's not really efficient to override the write() method every time we need that kind of feature.  
But this is a more important problem that will be handled later.  Two tasks have just been created regarding this issue: 
- Calendar's drag'n'drop usability
- Model state field inducing readonly mechanism

Hope that helped ;)

Regards, 
Anto

** Changed in: openobject-addons
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1082009

Title:
  HR > Leave Requests. User can write date fields of an already approved
  Leave Request

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  Version: 6.2dev-20121122-0001
  Related bug: 1005795

  A user gets leaves approved (e.g. sick days). Everybody can see this
  in the calendar (good!). Everybody can move the event around (bad!).
  This makes the calendar much less usable as a credible tool and source
  of information.

  (This can even happen accidently, because the drag-and-drop interface
  allows moving dates just too easy. There is not even an "undo"...)

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1082009/+subscriptions