← Back to team overview

openerp-india team mailing list archive

Re: [Bug 1219881] Re: Performance improvement on bank statement validation

 

@Joel,

Well Luc de Meyer told me Noviat had customers with 2000+ bank statement
lines (it's for this reason they have a per line state), so eventually the
performance boost isn't in this module, but I think they probably faced a
fixed a few issues and it could be worth asking them. Indeed in that code,
the performance thing for them was to bypass the normal write under certain
circumstances, and this is hacky for sure.

@Alexandre,

generally speaking, in the future, I would like to see properties to be all
handled by SQL without roundtrips between Python and Postgres. What do you
think? Syleam made some code at least for the reading part:
https://github.com/syleam/openerp-pdi-connector/tree/master/pdi_connector/sql
May
be worth repackaging or even including some of that in the core?

@all

as for m2o insertion/write triggering slow re-computation of the parent
container object (the bank statement here), whil I don't know if that's the
bottleneck here specifically, I confirm what Ferdinand says that this is
one one of the topmost PITA of the Openobject framework today. We have a
patch taking advantage of the awkward batch write API that trick orm.py
using a context key to ensure you can write multiple o2m records (using one
API call) and that function fields will only be computed once at the end.
Not sure this the thing that slows the most here. But for instance using
that patch, recomputing a 200 lines sale order after applying a new
pricelist went from 20+ minutes to 15 seconds. I'll try to post the the
patch somewhere later in the day. Could be useful in any case.


Good luck on that one.


On Tue, Sep 3, 2013 at 8:52 AM, Alexandre Fayolle - camptocamp <
alexandre.fayolle@xxxxxxxxxxxxxx> wrote:

> A potential source for this is the use of properties. AFAIR, there are a
> number of property access in a bank statement confirmation, and these
> are dreadfully slow.
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/1219881
>
> Title:
>   Performance improvement on bank statement validation
>
> Status in OpenERP Addons (modules):
>   New
>
> Bug description:
>   Hello,
>
>   Our customer need to validate bank statement with 15'000 lignes on
>   average . Today they slice the bank statement into 1000 lignes and,
>   even though, It takes hours to validate it.
>
>   Same probleme to cancel a bank statement.
>
>   This point becomes more and more critical for us especially in
>   e-commerce business.
>
>   Can you propose improvement please ?
>
>
>   Frederic Clementi
>   Camptocamp
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1219881/+subscriptions
>

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1219881

Title:
  Performance improvement on bank statement validation

Status in OpenERP Addons (modules):
  New

Bug description:
  Hello,

  Our customer need to validate bank statement with 15'000 lignes on
  average . Today they slice the bank statement into 1000 lignes and,
  even though, It takes hours to validate it.

  Same probleme to cancel a bank statement.

  This point becomes more and more critical for us especially in
  e-commerce business.

  Can you propose improvement please ?

  
  Frederic Clementi
  Camptocamp

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1219881/+subscriptions


References