openerp-india team mailing list archive

["Amit Parik \(OpenERP\)" <amp@xxxxxxxxxxx>]

** Changed in: openobject-addons
   Importance: Undecided => Low

** Changed in: openobject-addons
       Status: New => Confirmed

** Changed in: openobject-addons
     Assignee: (unassigned) => OpenERP R&D Addons Team 2 (openerp-dev-addons2)

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1131778

Title:
  [stock] _get_accounting_data_for_valuation tests accounts in the wrong
  order

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  In the stock_move model class, the _get_accounting_data_for_valuation
  method does comparisons between candidate accounts before testing if
  they are falsey or not, i.e.:

          if acc_dest == acc_valuation:
             ...
          if acc_src == acc_valuation:
              ...

          if not acc_src:
              ...
          if not acc_dest:
              ...
          if not journal_id:
              ...
          if not acc_valuation:
              ...

  I've found that my acc_src and acc_valuation are both falsey so I get
  a misleading error message. I think it would be better to test the
  candidate accounts for falseyness first.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1131778/+subscriptions