← Back to team overview

openerp-india team mailing list archive

[Bug 1204224] Re: [7.0] hr_timesheet_sheet - timesheet start and end are without timezone as it is date instead of datetime

 

Hi Yannick,

Sorry for the late reply.  Yes, I did try to patch hr_timesheet_sheet.py
with the code changes you made but after restarting the server I
couldn't connect to openerp from a browser.  I got a message saying 'no
handler found', so I think I may have made a mistake in patching the
python file (I'm not very experienced with this stuff).  Replacing the
patched file with the original fixed the problem with connecting.

Looks like a release may not be far away anyway!

Thanks,

Bill.

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1204224

Title:
  [7.0] hr_timesheet_sheet - timesheet start and end are without
  timezone as it is date instead of datetime

Status in OpenERP Community Backports (Addons):
  Fix Committed
Status in OpenERP Community Backports (Addons) 7.0 series:
  Fix Committed
Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  When entering attendances you might encounter serious issue as
  depending on the timezone, the attendances won't go on the correct
  timesheet.

  This is due because a timesheet has its start and end date defined in
  as DATE format. Thus it will mean timesheet start and end have no
  timezone defined.

  On the other hand, attendances will be in user timezone. This lead to
  attendances which will be out of scope of their timesheet if the
  timesheet was in local timezone too.

  Now let's say that a DATE in database means the timesheet is in users'
  timezone. Because a date isn't precise to be converted without
  overlapping from UTC to local timezone. And because it doesn't make
  sens for an Australian business to have its timesheets in UTC.

  Then we need to match attendances to this local timezone when trying
  to match the sheet_id on attendance. And as we have no timezone field
  defined on timesheet what we can do is taking this information from
  the employee.

  See linked MP

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1204224/+subscriptions


References