← Back to team overview

openerp-india team mailing list archive

[Bug 1218212] Re: [7.0/trunk] sale line margin is not computed if no product is selected

 

Hello Andrius, Twinkle and Yogesh.

I don't agree that bug is valid . If we don't have product then we can't calculate the margin because basically margin will be calculate based on product. If there is no product on sale order line when margin is not calculated which is good enough.
we have calculated the margin for check that how much margin we got for particular product

So I think the current behavior is good , For now I am not consider this
as a valid bug.

@Andrius : would you please provide a real use case which will satisfy
this requirement then after we can decide the correct status of this bug
report meanwhile I am setting this as a "Invaild". If you have a better
use case and good example you can feel free to reopen this.

Thank you!

** Changed in: openobject-addons
       Status: Fix Committed => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1218212

Title:
  [7.0/trunk] sale line margin is not computed if no product is selected

Status in OpenERP Addons (modules):
  Invalid

Bug description:
  addons revno: 9358

  Steps to reproduce:
  1. Install sale_margin module
  2. Create sale order line with Product, Cost Price and Price fields set
  3. Save sale order and observe Margin field correctly computed
  4. Open the same line and remove Product field (leaving Cost Price and Price fields as they were)
  5. Save sale order and observe Margin field NOT computing at all

  It turns out, if no product is selected, the system just ignores
  margin, although values for Cost Price and Price which are mandatory
  to compute margin is present.

  Please see patch attached

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1218212/+subscriptions


References