← Back to team overview

openerp-india team mailing list archive

[Bug 1210102] Re: Duplicate onchange partner_id methods in crm.lead

 

Hello,

In 7.0 we won't fix something about duplicate code. This is not
considered as a bug. In trunk the whole base_status module has been
removed, and all related methods quite refactored. This bug is therefore
not valid anymore in trunk.

** Changed in: openobject-addons
   Importance: Undecided => Wishlist

** Changed in: ocb-addons/7.0
       Status: New => Invalid

** Changed in: ocb-addons/7.0
   Importance: Undecided => Wishlist

** Changed in: openobject-addons
       Status: Fix Committed => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1210102

Title:
  Duplicate onchange partner_id methods in crm.lead

Status in OpenERP Community Backports (Addons):
  Invalid
Status in OpenERP Community Backports (Addons) 7.0 series:
  Invalid
Status in OpenERP Addons (modules):
  Invalid

Bug description:
  I noticed that in crm.lead, there are 2 onchange methods for partner_id:
  - on_change_partner
  - onchange_partner_id (defined in base_stage)

  The first one is called when changing the partner_id in the lead form.
  The second one when changing the partner_id in the opportunity form.
  The methods seem to be almost identical, except that the second one
  does an address_get for 'contact'.

  Is there any reason why the behavior when changing a partner_id is different between a lead and an opportunity?
  And why is there an onchange_partner_id method in base_stage? It has nothing to do with stages...

  Openerp version: 7.0-20130728-231025

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1210102/+subscriptions


References