← Back to team overview

openerp-india team mailing list archive

[Bug 1180769] Re: [7.0] hr_timesheet_sheet - attendances can be added on waiting approval and approved timesheets

 

Hello,

A fix was merged in 7.0, thanks for the report

revno: 10015 [merge]
revision-id: mat@xxxxxxxxxxx-20140425100856-lcpgyjdk4u632bws


** Changed in: openobject-addons
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1180769

Title:
  [7.0] hr_timesheet_sheet - attendances can be added on waiting
  approval and approved timesheets

Status in OpenERP Addons (modules):
  Fix Released

Bug description:
  Tested on runbot

  (Build 11071)
  server (4975)
  addons (9132)
  web (3922)

  Using "Track attendances for all employees" in HR settings

  If you send a timesheet in approval a bit early, you will still be
  able to sign in and sign out on that timesheet.

  Well we can discuss on this as it is in a field of scenario made by a human error.
  Should an employee be able to sign in if he returned to work on the week-end after having validated his timesheet on the friday? More likely, in any case he should ask a manager to reopen his timesheet? I think the timesheet in "Waiting approval" state shouldn't be alterable by the employee.

  It also causes some other issues, with such timesheet, let's say the
  employee sent his timesheet to approval and then added a sign in.

  The manager will be able to validate the timesheet as it is. He will
  have no warning when clicking on "Approve"

  Furthermore, when the manager has validated (let's say he did it early
  as it is a short week in the end of month) the timesheet, the employee
  will still be able to sign in and sign out on that timesheet!

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1180769/+subscriptions