← Back to team overview

openerp-india team mailing list archive

[Bug 1199386] Re: Portal Wizard uses wrong regular expression for emails

 

Life is filled with challenges—emotional struggles, relationship
tensions, personal disappointments, and spiritual confusion. Many people
are searching for direction, healing, and a deeper sense of purpose. If
that sounds like you, you're not alone. Christian counselling and
coaching offer a powerful path to healing and transformation by
integrating biblical principles with proven psychological methods.
Christian Coaching is a faith-based, goal-oriented approach to personal
development. It’s designed to help individuals move forward with purpose
by aligning their goals, mindset, and behaviors with biblical truths.
Unlike traditional therapy, which often focuses on healing past wounds,
Christian coaching is future-focused. It’s about where you’re going—not
just where you’ve been.  Contact us by:
https://theaffairsoftheheart.com/

-- 
You received this bug notification because you are a member of OpenERP
Community (OBSOLETE), which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1199386

Title:
  Portal Wizard uses wrong regular expression for emails

Status in Odoo Addons (MOVED TO GITHUB):
  Fix Released

Bug description:
  During testing with my email-address 'm@xxxxxxxxxxxxxx'  I noticed a
  couple of things:

  1. The partner contact with that email-address can't be given access
  to the portal by the portal wizard, it fails on creation of the user
  in addons/mail/res_user.py:68 :

          if not data.get('login', False):
              raise osv.except_osv(_('Invalid Action!'),...)))

  2. The login field is empty, because the portal wizard uses the email
  field to create a login in addons/portal/wizard/portal_wizard.py:177
  :

              'login': extract_email(wizard_user.email),

  The extract_email function in portal_wizard.py uses 'email_re' to determine what the login field should look like.
  'email_re' is defined as in multiple places, which is the first problem. It at least in  tools/mail.py and tools/import_email.py. (The latter contains email information from the 'steel-sa.com ' (?!?) domain by the way.)

  email_re = re.compile(r"""
      ([a-zA-Z][\w\.-]*[a-zA-Z0-9]     # username part
      @                                                          # mandatory @ sign
      [a-zA-Z0-9][\w\.-]*                       # domain must start with a letter ... Ged> why do we include a 0-9 then?
       \.
       [a-z]{2,3}                      # TLD
      )
      """, re.VERBOSE)

  Problems I see:

  1. The email_re is defined in multiple places; make it one;
  2. It forces to have email-addresses with at least 2 characters for the user part, of which the first must contain a letter; addresses like m@xxxxxxxxxx won't work then; is there a reason for this?
  3. the TLD must contain 2 or 3 characters, which is unsuitable for domains like .name or .info

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1199386/+subscriptions